Update grafana.md with additional details on setting loki.instance key value. #13541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated note at bottom of page with details on where to find the Prometheus job_name value, the command to set the value as the loki.instance key and the command to check/verify the value that was set. Signed-off-by: JohnHammell <git@johnhammell.com>
|
Heads up @ru-fu - the "Documentation" label was applied to this issue. |
ru-fu
reviewed
Jun 4, 2024
Co-authored-by: Ruth Fuchss <ruth.fuchss@canonical.com> Signed-off-by: JohnHammell <git@johnhammell.com>
Co-authored-by: Ruth Fuchss <ruth.fuchss@canonical.com> Signed-off-by: JohnHammell <git@johnhammell.com>
Co-authored-by: Ruth Fuchss <ruth.fuchss@canonical.com> Signed-off-by: JohnHammell <git@johnhammell.com>
simondeziel
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
LGTM, thanks again John!
The CLA check failure can safely be ignored as John is a returning contributor.
Update: the CLA check passed on retry, apparently the self-signed cert was replaced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated note at bottom of page with details on where to find the Prometheus job_name value, the command to set the value as the loki.instance key and the command to check/verify the value that was set.