Storage: Don't use nvme CLI to retrieve subsystems #13647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The output format of 'nvme list-subsys -o json' has changed between jammy and noble. By using sysfs directly we are independent from future output changes Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
roosterfish
force-pushed
the
powerflex_use_sys
branch
from
7cdffc5
to
65125ad
Compare
tomponline
changed the title
|
@roosterfish happy to merge this? |
Jup, still wanted to run through the entire But there is an abundance of volume actions happening before that so it feels safe to say that this change doesn't break anything. |
tomponline
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output format of
nvme list-subsys -o jsonhas changed as part of moving the LXD snap fromcore22tocore24(See canonical/lxd-pkg-snap#471). By using sysfs directly we are independent from future output changes.