Storage: Check if device has appeared in /dev/zd* when activating or creating a volume #13662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MusicDin
changed the title
1 task
|
Has this been tested on latest/edge? |
|
Yes, on this branch/PR. Here is the log: zfs-storage-disks-vm.log |
tomponline
reviewed
Jun 25, 2024
tomponline
reviewed
Jun 25, 2024
tomponline
reviewed
Jun 25, 2024
tomponline
reviewed
Jun 25, 2024
MusicDin
force-pushed
the
fix/zfs-locate-zvol
branch
2 times, most recently
from
57ddd74
to
b394f90
Compare
Signed-off-by: Din Music <din.music@canonical.com>
MusicDin
force-pushed
the
fix/zfs-locate-zvol
branch
from
b394f90
to
a61016b
Compare
tomponline
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the regression introduced in #13656 where only the path
/dev/zvol/<dataset>is checked for existence. Instead, modify the approach to obtain the device path as done in theGetVolumeDiskPathmethod. This ensures that the device path is correctly identified, whether it appears as/dev/zvol/<dataset>or/dev/zd*.The previously failing lxd-ci test suite
storage-disks-vmis passing locally.