lxd-agent: Retry VM hotplug directory share mounts #13674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Sometimes the hotplug event is received from LXD before the virtiofs device is available in the guest VM. So retry several times before giving up to allow it to be activated. Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
In this case we need it to ensure non-zero exit code is returned. Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
tomponline
force-pushed
the
tp-agent-disk-wait
branch
from
7af37c2
to
70c0d45
Compare
simondeziel
previously approved these changes
Jun 27, 2024
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
simondeziel
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the hotplug event is received from LXD before the virtiofs device is available in the guest VM.
So retry several times before giving up to allow it to be activated.
This, in conjunction with a sleep in the lxd-ci tests makes the storage-disks-vm tests more reliable:
canonical/lxd-ci#210
Also enables lxd-agent syslog logging for better feedback about what the agent is doing.
Also standardises using the
errfield in contextual logging rather thanerror.The majority of uses were already using
err, but there were a few stragglers usingerror.