Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport(fix): Pin Prometheus and Grafana revisions (#82) #92

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

orfeas-k
Copy link
Contributor

@orfeas-k orfeas-k commented Sep 26, 2023

This PR backports #82 needed for integration tests to succeed.
Refs canonical/bundle-kubeflow#688
Refs canonical/bundle-kubeflow#690

This is a temporary patch until we migrate to Juju 3.1:
* Pin Prometheus revision when deploying from `latest` to avoid fetching
  recent patches of the charm which assume `juju >= 3.0.3`. Revision 137
  was the last one seen working properly in our CI integration tests.
* Pin Grafana revision when deploying from `latest` to avoid fetching
  recent patches of the charm which fail to install on Juju 2.9.
  Revision 89 was the last one working properly in our CI integration
  tests.

Signed-off-by: Phoevos Kalemkeris <phoevos.kalemkeris@canonical.com>
Copy link
Contributor

@DnPlas DnPlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @orfeas-k !

@orfeas-k orfeas-k merged commit 4a45026 into track/2.0 Sep 26, 2023
7 checks passed
@orfeas-k orfeas-k deleted the backport-pin-prometheus-grafana branch September 26, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants