Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test for intermediate CA #4264

Closed
wants to merge 1 commit into from

Conversation

bschimke95
Copy link
Contributor

This test verifies that microk8s can handle intermediate CAs. For that it:

  1. Creates an intermediate CA certificate with openssl
  2. Uses microk8s refresh-certs to apply this certificate in a microk8s cluster.
  3. Verifies that all services come up again and that joining a new node to the cluster still works.

@bschimke95 bschimke95 force-pushed the MK-1422/intermediate-ca-integration branch 2 times, most recently from 2ad1922 to 2951e9d Compare October 25, 2023 16:26
self.attached = True
self.vm_name = attach_vm

if not enable_ipv6:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This VM code is copied from test-cluster.py.

The only added the flag enable_ipv6 and this check in the __init__ method


# Channel we want to test. A full path to a local snap can be used for local builds
channel_to_test = (
"latest/edge/intermediate-ca" # os.environ.get("CHANNEL_TO_TEST", "latest/stable")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This branch contains the fixes for the intermediate CA verification (#4256).

Hard-coding this here is a temporary hack to see if the CI passes

@bschimke95 bschimke95 requested a review from neoaggelos October 26, 2023 11:37
@bschimke95 bschimke95 marked this pull request as ready for review October 26, 2023 11:37
@bschimke95 bschimke95 force-pushed the MK-1422/intermediate-ca-integration branch 2 times, most recently from f5a8f14 to f55bf5c Compare October 26, 2023 15:12
Copy link
Contributor

@neoaggelos neoaggelos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the .tox files, they seem to be added by mistake?

This test verifies that microk8s can handle intermediate CAs.
For that it:

1. Creates an intermediate CA certificate with openssl
2. Uses `microk8s refresh-certs` to apply this certificate in a microk8s
   cluster.
3. Verifies that all services come up again and that joining a new node
   to the cluster still works.
@bschimke95 bschimke95 force-pushed the MK-1422/intermediate-ca-integration branch from f55bf5c to 1fbdfe2 Compare October 27, 2023 07:21
@bschimke95
Copy link
Contributor Author

Thanks, that slipped through.

@bschimke95 bschimke95 requested a review from neoaggelos October 27, 2023 12:37
@bschimke95
Copy link
Contributor Author

bschimke95 commented Dec 4, 2023

Closed, as not required anymore.

@bschimke95 bschimke95 closed this Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants