Use https url to perform connectivity check #4284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous check was for ICMP which may not be possible and doesn't confirm whether further steps will work correctly
|
@ktsakalozos Re-signed CLA (using email as launchpad id this time) and joined group |
|
Hi @smithyuk Could you please check again? |
Re-signed, I think this is looking up based on email and not whatever I set my GitHub username to in the CLA signing. So I signed with the same email that my commit was as. Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Change internet connectivity check to use HTTPS, previous check was for ICMP which may not be possible and doesn't confirm whether further steps will work correctly
Closes #3978
Changes
Change internet connectivity check to use HTTPS
Testing
Tested code in isolation
Possible Regressions
Checklist
Notes