From a6ac58eb30286d34b269a1c585e5c8cc894ae373 Mon Sep 17 00:00:00 2001 From: michael Date: Tue, 20 Aug 2024 13:12:57 +0300 Subject: [PATCH] remove debug log --- .../v0/kubernetes_compute_resources_patch.py | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/lib/charms/observability_libs/v0/kubernetes_compute_resources_patch.py b/lib/charms/observability_libs/v0/kubernetes_compute_resources_patch.py index 6887d96..9c05158 100644 --- a/lib/charms/observability_libs/v0/kubernetes_compute_resources_patch.py +++ b/lib/charms/observability_libs/v0/kubernetes_compute_resources_patch.py @@ -307,9 +307,11 @@ def _retry_on_condition(exception): return True return False + class PatchFailedError(Exception): """Raised when patching K8s resources requests and limits fails.""" + class K8sResourcePatchFailedEvent(EventBase): """Emitted when patching fails.""" @@ -412,12 +414,6 @@ def is_ready(self, pod_name, resource_reqs: ResourceRequirements): Returns: bool: A boolean indicating if the service patch has been applied and is in effect. """ - logger.debug( - "reqs=%s, templated=%s, actual=%s", - resource_reqs, - self.get_templated(), - self.get_actual(pod_name), - ) return self.is_patched(resource_reqs) and equals_canonically( # pyright: ignore resource_reqs, self.get_actual(pod_name) # pyright: ignore ) @@ -428,7 +424,7 @@ def apply(self, resource_reqs: ResourceRequirements) -> None: # charm would be stuck in unknown/lost. if self.is_patched(resource_reqs): logger.debug(f"resource requests {resource_reqs} are already patched.") - return + return self.client.patch( StatefulSet, @@ -550,7 +546,6 @@ def _patch(self) -> None: logger.exception(msg) raise PatchFailedError(msg) from e - except ValueError as e: msg = f"Kubernetes resources patch failed: {e}" logger.exception(msg)