Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harness should always provide the remote app name in relation-broken #1128

Closed
tonyandrewmeyer opened this issue Feb 9, 2024 · 1 comment · Fixed by #1130
Closed

Harness should always provide the remote app name in relation-broken #1128

tonyandrewmeyer opened this issue Feb 9, 2024 · 1 comment · Fixed by #1130
Assignees
@tonyandrewmeyer
Labels
bug Something isn't working small item testing Related to ops.testing

Comments

@tonyandrewmeyer
Copy link
Contributor

Although it seems like sometimes JUJU_REMOTE_APP is not set in relation-broken, the conclusion in the Juju investigation was that this should not happen, and it couldn't be reproduced.

We should remove the special-casing in Harness that acts as if this is the case.
@tonyandrewmeyer tonyandrewmeyer added bug Something isn't working testing Related to ops.testing small item labels Feb 9, 2024
@jameinel
Copy link
Member

jameinel commented Feb 9, 2024 via email

@tonyandrewmeyer tonyandrewmeyer mentioned this issue Feb 14, 2024
Merged
@tonyandrewmeyer tonyandrewmeyer self-assigned this Feb 14, 2024
@tonyandrewmeyer tonyandrewmeyer mentioned this issue Feb 14, 2024
Closed
benhoyt pushed a commit that referenced this issue Feb 27, 2024
@tonyandrewmeyer
fix(testing): set JUJU_REMOTE_APP and allow fetching relation data in…
c623461 
… relation-broken (#1130)

As far as the Juju team and I have been able to tell (see [comments in the Juju issue](https://bugs.launchpad.net/juju/+bug/1960934)) `JUJU_REMOTE_APP` is always set in relation-broken events.

This PR removes the `Harness` behaviour that simulates `JUJU_REMOTE_APP` *not* being available (which was never consistently the case anyway) and the model code that blocks getting remote data during relation-broken (which is discouraged in the case where the entire integration is going away, but is permitted).

Fixes #1128.
@sed-i sed-i mentioned this issue Sep 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tonyandrewmeyer tonyandrewmeyer

Labels
bug Something isn't working small item testing Related to ops.testing
Projects
None yet
Milestone
No milestone
2 participants
@jameinel @tonyandrewmeyer