feat: add pebble.CheckInfo.change_id field #1197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is new with health checks being implemented as changes and tasks (canonical/pebble#409). We shouldn't merge this before that Pebble PR is merged, just in case anything changes.
benhoyt
changed the title
tonyandrewmeyer
approved these changes
Apr 24, 2024
| ) | ||
|
|
||
| def __repr__(self): | ||
| return ('CheckInfo(' | ||
| f'name={self.name!r}, ' | ||
| f'level={self.level!r}, ' | ||
| f'level={self.level}, ' |
There was a problem hiding this comment.
This seems like it's better if level is a CheckLevel and worse if it's a str. Maybe both should be explicitly handled?
There was a problem hiding this comment.
True. However, realistically this is always going to be a CheckLevel (UP or DOWN). I think I'll leave this as is for now, as explicitly handling both is messy. We can update them all if we want in a later PR. But right now we don't test repr() and don't guarantee that eval(repr(x)) works, so I think it's probably fine as is.
IronCore864
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is new with health checks being implemented as changes and tasks (canonical/pebble#409).
Ops/charms will likely not use this new field. Even once we have the new
change-updatedevent, that has a.get_change()method to get the change directly. But we're adding it to the Pebble client/types for completeness.We shouldn't merge this before that Pebble PR is merged, just in case anything changes.