docs: clarify that SecretNotFound may be raised for permission errors #1231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e caller can't view it.
|
Oh, I see -- we're closing #1229, and this PR goes on the assumption that the Juju bug will be fixed. |
Yes - my assumption is that since @wallyworld agrees that Juju should be consistent that the Juju bug will get fixed. But also: this is already the case for everything other than user secrets. If we wanted it to reflect the current behaviour, then it should have this change and also a new "raises" item of "ModelError: when the secret is a user secret and the charm does not have permission to view it". My preference would be to not add that now on the assumption that it won't be true soon (for some value of "soon"). |
benhoyt
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noticed in #1229,
get_secret()may raiseSecretNotFoundErrorif the secret does exist but the caller does not have permission to view it, so make this explicit in the documentation.