-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: use Sphinx 8 #1303
docs: use Sphinx 8 #1303
Conversation
Would it make sense just to wait till we can use Sphinx 8, to avoid busy-work? In the meantime, we could relax 6.2.1 to 6.x. |
6.2.1 is the latest 6.x release, and Sphinx 6.x is no longer supported. In fact they rejected my bug report wrt. py 3.12.4. |
I'll try to update this to Sphinx 8. |
Looks nice, it seems nothing changed, which is good though! |
Nothing broke visually The only real difference detected by tooling is that inline code spans are 1px off, but I can't see this with my own eye. The search behaviour is different:
|
6ee1294
to
8330a61
Compare
rebased on latest main, just in case |
This is much better. For example, a while back we had a complaint about searching for "secret" not providing useful results, which was true. Now it gives you the most obvious result first and lots of other good ones afterwards. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, search is much better, thanks!
Edit: re-locked with Sphinx 8 now that furo supports it.