Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Live reload with sphinx-autobuild #1323

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

dimaqq
Copy link
Contributor

@dimaqq dimaqq commented Aug 20, 2024

  • it works 🎉
  • sphinx-autobuild was already included in pyproject.toml, was there already a way to rebuild on change?
  • let's paint that bike shed and decide on the tox -e <name> for this

@dimaqq
Copy link
Contributor Author

dimaqq commented Aug 20, 2024

WDYT folks, do we need it or not?

@benhoyt
Copy link
Collaborator

benhoyt commented Aug 20, 2024

I'm not opposed to it. I think I would have used this when working on docs(trings). docs-live is okay. Or maybe docs-server?

@tonyandrewmeyer
Copy link
Contributor

I'm not opposed to this, but I doubt I would use it. I tend to write, then do tox -e docs and read the output to make sure I didn't mess up a reference etc and then refresh the page in my browser. It doesn't seem like this would change that workflow enough that I would make use of it. But again, not opposed to it if it would be useful for others.

docs-live-reload?

docs/conf.py Outdated Show resolved Hide resolved
@dimaqq dimaqq requested a review from IronCore864 August 28, 2024 05:47
@dimaqq
Copy link
Contributor Author

dimaqq commented Aug 29, 2024

I've addressed the code comments, the change is smaller now.
I think it's good to go :)

Copy link
Contributor

@tonyandrewmeyer tonyandrewmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't have any objection to this, but I also don't really see its value. I tried it out, thinking that I could live see any changes I made to the docs, but that isn't the case, because the docs are in ops/ and it's watching for changes in docs/. So this would seem to only be useful when making changes to the custom config or the index, which are both pretty rare in my experience.

Could you please update the PR description to better explain what the PR does? Then it can also be the details for the commit to main, and they nicely match for future looking back.

@benhoyt
Copy link
Collaborator

benhoyt commented Aug 29, 2024

the docs are in ops/ and it's watching for changes in docs/. So this would seem to only be useful when making changes to the custom config or the index, which are both pretty rare in my experience.

Oooh, I'd missed that. Yeah, I don't think it's worth it then. Can it watch ops/ as well?

@dimaqq dimaqq merged commit 79e89df into canonical:main Aug 29, 2024
33 of 34 checks passed
@dimaqq dimaqq deleted the sphinx-autobuild branch August 29, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants