-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Live reload with sphinx-autobuild #1323
Conversation
WDYT folks, do we need it or not? |
I'm not opposed to it. I think I would have used this when working on docs(trings). |
I'm not opposed to this, but I doubt I would use it. I tend to write, then do
|
0a4ff80
to
fc5eb88
Compare
fc5eb88
to
bb99c01
Compare
I've addressed the code comments, the change is smaller now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still don't have any objection to this, but I also don't really see its value. I tried it out, thinking that I could live see any changes I made to the docs, but that isn't the case, because the docs are in ops/
and it's watching for changes in docs/
. So this would seem to only be useful when making changes to the custom config or the index, which are both pretty rare in my experience.
Could you please update the PR description to better explain what the PR does? Then it can also be the details for the commit to main, and they nicely match for future looking back.
Oooh, I'd missed that. Yeah, I don't think it's worth it then. Can it watch |
tox -e <name>
for this