Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add the description field to SecretInfo #1338

Merged
merged 1 commit into from
Aug 26, 2024
Merged

feat: add the description field to SecretInfo #1338

merged 1 commit into from
Aug 26, 2024

Conversation

tonyandrewmeyer
Copy link
Contributor

The SecretInfo class exposed all the fields from secret-info-get exception description. This PR adds that field as well.

Fixes #1289.

benhoyt
benhoyt approved these changes Aug 26, 2024
View reviewed changes
Copy link
Collaborator

@benhoyt benhoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tonyandrewmeyer tonyandrewmeyer merged commit a0b1480 into canonical:main Aug 26, 2024
32 checks passed
@tonyandrewmeyer tonyandrewmeyer deleted the add-secret-description branch August 26, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benhoyt benhoyt benhoyt approved these changes

@dimaqq dimaqq dimaqq approved these changes

@james-garner-canonical james-garner-canonical Awaiting requested review from james-garner-canonical

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose "description" in SecretInfo
3 participants
@tonyandrewmeyer @dimaqq @benhoyt