docs: explicitly document that collect-status is is run on *every* hook #1399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Tony Meyer <tony.meyer@gmail.com>
tonyandrewmeyer
approved these changes
Sep 27, 2024
benhoyt
reviewed
Sep 29, 2024
benhoyt
approved these changes
Sep 29, 2024
tonyandrewmeyer
pushed a commit
to tonyandrewmeyer/operator
that referenced
this pull request
Oct 4, 2024
…ok (canonical#1399) For backwards compatibility, collect-status will continue to run at the end of every hook, even if the charm does not provide any observers for that hook. Make this explicit in the documentation. Closes canonical#1265.
tonyandrewmeyer
pushed a commit
to tonyandrewmeyer/operator
that referenced
this pull request
Oct 9, 2024
…ok (canonical#1399) For backwards compatibility, collect-status will continue to run at the end of every hook, even if the charm does not provide any observers for that hook. Make this explicit in the documentation. Closes canonical#1265.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We decided in #1265 that, for backwards compatibility, the behaviour of collect-status won't be changing. That is, it will continue to run at the end of every hook, even if the charm does not provide any observers for that hook. This PR makes this clear in the docs. Closes #1265.