Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: a better way than commenting out external repos #1463

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

dimaqq
Copy link
Contributor

@dimaqq dimaqq commented Nov 27, 2024

Proposing a fix to #1461 deleting commented out repos

Copy link
Collaborator

@benhoyt benhoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a reasonable approach -- thanks.

Copy link
Contributor

@tonyandrewmeyer tonyandrewmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I gather what will happen here is that the commit line will still get bumped, but it will remain disabled. That seems reasonable to me.

I do think we need to document this somewhere, though. That could just be a disabled: false on the ones that are ok, or maybe it should be in HACKING.md or the action's readme.md or somewhere? Otherwise once nothing is disabled, it won't be obvious that this is how you do it (although the if will still be there).

I didn't actually run the script to verify that this will probably work, but looking over the code it seems like it, and we'll see soon enough if not, and it wouldn't be disruptive anyway.

@dimaqq dimaqq merged commit 0ac751f into canonical:main Nov 27, 2024
29 checks passed
@dimaqq dimaqq mentioned this pull request Nov 27, 2024
tonyandrewmeyer pushed a commit to tonyandrewmeyer/operator that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants