Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: a better way than commenting out external repos #1463

Merged
merged 1 commit into from
Nov 27, 2024
Merged

ci: a better way than commenting out external repos #1463

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .github/workflows/observability-charm-tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,9 @@ jobs:
include:
- charm-repo: canonical/alertmanager-k8s-operator
commit: fe233592f9324a6cf4aa9dbc71577ee170cf9eb3 # rev138 2024-10-18T12:11:02Z
# Waiting for an upstream PR:
# https://github.com/canonical/prometheus-k8s-operator/pull/639
#- charm-repo: canonical/prometheus-k8s-operator
# commit: 7518ec8343941ca91248614fd8f2d50fdd9e068c # rev135 2024-09-06T12:10:02Z
- charm-repo: canonical/prometheus-k8s-operator
commit: 7518ec8343941ca91248614fd8f2d50fdd9e068c # rev135 2024-09-06T12:10:02Z
disabled: true # Waiting for an upstream PR: https://github.com/canonical/prometheus-k8s-operator/pull/639
- charm-repo: canonical/grafana-k8s-operator
commit: 07a52a65f272e115ab786f30cdb3b53be6b34bb7
steps:
Expand All @@ -39,7 +38,9 @@ jobs:
run: pip install tox~=4.2

- name: Run the charm's unit tests
if: !matrix.disabled
run: tox -vve unit

- name: Run the charm's static analysis checks
if: !matrix.disabled
run: tox -vve static-charm