Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storage tests: add a missing test_ method prefix #80

Merged
merged 1 commit into from
Dec 11, 2019
Merged

Storage tests: add a missing test_ method prefix #80

merged 1 commit into from
Dec 11, 2019

Conversation

dshcherb
Copy link
Contributor

Unfortunately, test_storage_tool_errors was silently skipped due to a
missing prefix - it was counted as a method rather than a test case.

Storage tests: add a missing test_ method prefix
79783aa 
Unfortunately, test_storage_tool_errors was silently skipped due to a
missing prefix - it was counted as a method rather than a test case.
@dshcherb dshcherb requested review from jameinel and johnsca December 11, 2019 08:48
jameinel
jameinel approved these changes Dec 11, 2019
View reviewed changes
Copy link
Member

@jameinel jameinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. That's definitely one of those times where the mantra "see the test fail before you fix it" can help. :)

johnsca
johnsca approved these changes Dec 11, 2019
View reviewed changes
Copy link
Contributor

@johnsca johnsca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 As John said, I'm a big fan of writing the test first and making sure it fails before making the change itself, even if I don't always follow my own advice in that regard. :)

@johnsca johnsca merged commit 82d570e into canonical:master Dec 11, 2019
tonyandrewmeyer pushed a commit to tonyandrewmeyer/operator that referenced this pull request Sep 27, 2024
@PietroPasotti
Merge pull request canonical#80 from canonical/fix-falsy-config-defaults
f5ac9c8 
fix falsy config defaults
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnsca johnsca johnsca approved these changes

@jameinel jameinel jameinel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dshcherb @jameinel @johnsca