Rename Event to EventSource #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per discussions, we're keeping the wrapping of event types explicit but renaming `Event` to avoid confusion between it and `EventBase`.
niemeyer
approved these changes
Dec 16, 2019
jameinel
approved these changes
Dec 16, 2019
ops/framework.py
Outdated
| class Event: | ||
| """Event creates class descriptors to operate with events. | ||
| class EventSource: | ||
| """EventSource creates class descriptors to operate with events. |
There was a problem hiding this comment.
I wonder if we tweak this doc string if it also would help make it clearer why you want to use it.
This was referenced Dec 16, 2019
camille-rodriguez
added a commit
to camille-rodriguez/mssql
that referenced
this pull request
Jan 10, 2020
camille-rodriguez
added a commit
to camille-rodriguez/mssql
that referenced
this pull request
Jan 10, 2020
camille-rodriguez
added a commit
to camille-rodriguez/mssql
that referenced
this pull request
Jan 14, 2020
tonyandrewmeyer
pushed a commit
to tonyandrewmeyer/operator
that referenced
this pull request
Sep 27, 2024
…raft-yaml Support unified charmcraft yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussions, we're keeping the wrapping of event types explicit but renaming
Eventto avoid confusion between it andEventBase.