consistency checker gives false positives when working with copied objects

[PietroPasotti]

This is a regression from scenario 6 (or perhaps it's good that it fails?)

MWE:

from ops import CharmBase
from scenario import Context
def test_relation_evt():
    ctx = Context(CharmBase, meta={"name": "mateusz",
                                   "requires": {"a": {"interface": "b"}}})
    rel = Relation("a", interface="b")
    rel_cpy = replace(rel, remote_app_data={"foo": "bar"})

    ctx.run(ctx.on.relation_changed(rel_cpy), State(relations={rel}))
    # scenario.errors.InconsistentScenarioError: Inconsistent scenario.
    # The following errors were found: cannot emit a_relation_changed because 
    # relation 1 is not in the state.

culprit is this line in the consistency checker:

if event.relation not in state.relations:
    ... <mark as inconsistent>

Proposed solution:

if event.relation.id not in [r.id for r in state.relations]:
    ...

[tonyandrewmeyer]

Proposed solution:

if event.relation.id not in [r.id for r in state.relations]:
    ...

I think this is the right solution - you can't have relations with the same ID even if they aren't the same Relation object.

Might need to check some of the others like containers as well?

[tonyandrewmeyer]

Moved to canonical/operator#1429