Fix minimal images on gce and ec2 #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-dubs
force-pushed
the
fix-minimal-images-on-gce-and-ec2
branch
2 times, most recently
from
3e7e89d
to
6feda1c
Compare
blackboxsw
approved these changes
Sep 13, 2024
| @@ -155,7 +155,7 @@ def test_public_api(cloud: BaseCloud): | |||
| ], | |||
| indirect=True, | |||
| ) | |||
| def test_public_api_mininal_images(cloud: BaseCloud): | |||
| def test_public_api_minimal_images(cloud: BaseCloud): | |||
There was a problem hiding this comment.
I much prefer mininal.... But, if we prefer to be correct and all +1.
tests/unit_tests/gce/test_cloud.py
Outdated
| ], | ||
| ) | ||
| def test_get_name_filter(self, release, image_type, expected_name_filter): | ||
| gce = FakeGCE(tag="tag") |
There was a problem hiding this comment.
Same, fake tag=tag param unnecessary. not a blocker to landing. Resolve or not and merge as you see fit.
There was a problem hiding this comment.
alright removed all references to tags for these fake classes since its a noop.
a-dubs
force-pushed
the
fix-minimal-images-on-gce-and-ec2
branch
2 times, most recently
from
d431fe7
to
8aedfe7
Compare
PR canonical#410 introduced minimal images and added integration test coverage for EC2 and GCE but the helper functions used to find images on those clouds were not updated. This fixes this issue and should include all the remaining functionality needed for minimal images to work on those clouds.
a-dubs
force-pushed
the
fix-minimal-images-on-gce-and-ec2
branch
from
8aedfe7
to
1d0c7f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please just rebase, do not squash 🫡