-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interactive Execute on Container #348
Conversation
Signed-off-by: Felix Engelmann <fe-github@nlogn.org>
Signed-off-by: Felix Engelmann <fe-github@nlogn.org>
Signed-off-by: Felix Engelmann <fe-github@nlogn.org>
Signed-off-by: Felix Engelmann <fe-github@nlogn.org>
Codecov Report
@@ Coverage Diff @@
## master #348 +/- ##
==========================================
+ Coverage 96.83% 96.89% +0.05%
==========================================
Files 12 12
Lines 980 997 +17
Branches 110 111 +1
==========================================
+ Hits 949 966 +17
Misses 12 12
Partials 19 19
Continue to review full report at Codecov.
|
Signed-off-by: Felix Engelmann <fe-github@nlogn.org>
Signed-off-by: Felix Engelmann <fe-github@nlogn.org>
I think that this is an interesting addition, although it ought to come with a "health warning" as the caller has to do quite a bit of work to complete the command. I think that perhaps the function should be renamed slightly (to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good; just a few minor formatting and comment changes.
Hi, this is the great addition. Now I am using just customized execute() function to get data for using web terminal in .js. |
Signed-off-by: Felix Engelmann <fe-github@nlogn.org>
Signed-off-by: Felix Engelmann <fe-github@nlogn.org>
Thanks very much for the changes; I now understand the use case! Essentially, you provide these back to a web browser app and that does the handling of the websockets. Very interesting. Thanks for the addition. |
It might be interesting to get the websockets to interact with a container, e.g. on a shell.
Therefore interactive_execute on a container returns a data and control websocket. By design of lxd, they include a secret, so no additional authentication is required to connect to them. They are then perfect to be passed to a web terminal.