Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare 2.3.2 release #570

Merged
merged 4 commits into from
Jan 17, 2024
Merged

Prepare 2.3.2 release #570

merged 4 commits into from
Jan 17, 2024

Conversation

simondeziel
Copy link
Member

@simondeziel simondeziel commented Jan 15, 2024 •
edited
Loading 

$ python3 -m twine check --strict dist/*
Checking dist/pylxd-2.3.2-py3-none-any.whl: PASSED
Checking dist/pylxd-2.3.2.tar.gz: PASSED

@simondeziel simondeziel changed the title Prepare 2.3.2 Prepare 2.3.2 release Jan 15, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4ecdc75) 97.77% compared to head (b246eb9) 97.77%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #570   +/-   ##
=======================================
  Coverage   97.77%   97.77%           
=======================================
  Files          32       32           
  Lines        3057     3057           
=======================================
  Hits         2989     2989           
  Misses         68       68

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simondeziel simondeziel marked this pull request as ready for review January 16, 2024 20:58
roosterfish
roosterfish requested changes Jan 17, 2024
View reviewed changes
setup.cfg Outdated Show resolved Hide resolved
@simondeziel
setup.cfg: add long_description_content_type
3cab970 
Addresses `twine check --strict` warning:

```
WARNING  `long_description_content_type` missing. defaulting to `text/x-rst`.
```

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
github: remove space on empty line
fb7b164 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
pylxd/models: use more f-strings
a1b9c17 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
setup.cfg: bump version to 2.3.2
b246eb9 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
roosterfish
roosterfish approved these changes Jan 17, 2024
View reviewed changes
Copy link

@roosterfish roosterfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@simondeziel simondeziel merged commit 86a897d into canonical:main Jan 17, 2024
10 checks passed
@simondeziel simondeziel deleted the prepare-2.3.2 branch January 17, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roosterfish roosterfish roosterfish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simondeziel @roosterfish