Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sentinel Master units ip to the app databag #95

Closed
alithethird opened this issue Aug 20, 2024 · 9 comments
Closed

Add Sentinel Master units ip to the app databag #95

alithethird opened this issue Aug 20, 2024 · 9 comments
Assignees
Labels
enhancement New feature or request

Comments

@alithethird
Copy link
Contributor

alithethird commented Aug 20, 2024

When multiple units of Redis is deployed the units put their ip into the unit databag and consumer charms can not find which unit is the leader. An example bug is here: canonical/discourse-k8s-operator#268

This also fixes the issue where after a reboot the consumer charm doesn't refresh the redis ip. Ip refreshes in the unit databag but the charm doesn't read that because its cashed. An example bug is here: https://bugs.launchpad.net/juju/+bug/2063087

Adding the Sentinel Master units ip to the app databag would fix both of these bugs.

Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/DPE-5200.

This message was autogenerated

@reneradoi reneradoi self-assigned this Aug 21, 2024
@reneradoi
Copy link
Contributor

Hello @alithethird thanks for creating this request. Just for clarification: You need the Redis Sentinel leader information, not the juju leader, correct?

@alithethird
Copy link
Contributor Author

Hi @reneradoi. Thanks for the answer. Sorry I am not very familiar with and thought they were the same. I need the one that has write access to the database. That is the Sentinel leader I guess?

@reneradoi reneradoi added the enhancement New feature or request label Aug 21, 2024
@reneradoi
Copy link
Contributor

Yes @alithethird that would be the Sentinel leader.

@alithethird
Copy link
Contributor Author

Thanks for clarifying that. I will update the issue accordingly.

@alithethird alithethird changed the title Add master units ip to the app databag Add Sentinel Master units ip to the app databag Aug 21, 2024
@AmberCharitos
Copy link

This is also impacting the Commercial Systems team deployment of Superset. Commenting here for visibility. I see there is a PR to resolve so will monitor that.

@reneradoi
Copy link
Contributor

New version has been released as revision 35 to Charmhub.

@alithethird
Copy link
Contributor Author

Thanks a lot!

@reneradoi
Copy link
Contributor

Closing the issue as this has been provided with #96.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants