Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a charm lib for pod-defaults relation #41

Closed
NohaIhab opened this issue Jan 10, 2024 · 1 comment · Fixed by #42
Closed

Implement a charm lib for pod-defaults relation #41

NohaIhab opened this issue Jan 10, 2024 · 1 comment · Fixed by #42
Labels
enhancement New feature or request

Comments

@NohaIhab
Copy link
Contributor

Context

resource-dispatcher charm is currently using SDI to handle the relation pod-defaults, the team is moving away from using SDI, so we should write a charm library to handle the relation events and data transfer logic.

What needs to get done

  1. Implement the charm library in resource-dispatcher with a provider and requirer classes
  2. add tests for the charm library
  3. rewrite the charms that use this relation to use the library, the charms are mlflow-operator and the new ngc charm -> tasks to be created

Definition of Done

  • resource-dispatcher charm is handling the pod-defaults relation correctly using the charm library rather than SDI
  • there is good test coverage for the charm library and tests are passing
@NohaIhab NohaIhab added the enhancement New feature or request label Jan 10, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-5184.

This message was autogenerated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant