tests(integration): Apply seldondeployments in namespace default
#220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor integration tests after hitting issue #218. This is a workaround for the issue. At the same time, it is needed to revert those back since up until now, integration tests were applying seldondeployments to the namespace created by Juju. In production, this would be `kubeflow` and we would never apply something there.
orfeas-k
force-pushed
the
refactor-integration-tests
branch
from
478eb0b to
28f9bfd
Compare
orfeas-k
changed the title
default
kimwnasptd
approved these changes
Oct 5, 2023
NohaIhab
added a commit
that referenced
this pull request
Oct 19, 2023
update tox.ini's update-requirements (#215) Updates tox.ini's update-requirements as described in canonical/argo-operators#100 Ref canonical/kubeflow-ci#59 doc link (#214) tests(integration): Apply seldondeployments in namespace `default` (#220) * tests(integration): Refactor Refactor integration tests after hitting issue #218. This is a workaround for the issue. At the same time, it is needed to revert those back since up until now, integration tests were applying seldondeployments to the namespace created by Juju. In production, this would be `kubeflow` and we would never apply something there. * tests(integration): Rename DEFAULT_NAMESPACE to WORKLOADS_NAMESPACE Contributing (#219) Co-authored-by: Orfeas Kourkakis <orfeas.kourkakis@canonical.com> chore: bump seldon charm 1.15 -> 1.17.1 for CKF release 1.8 (#216) * bump seldon-core-operator 1.15.0 -> 1.17.1 for CKF 1.8 * manifests: Update CRD according to upstream manifests * manifests: Update manifests roles names * Use upstream images 1.17.1 for seldon servers * tests(unit): Modify expected pebble plan * tests(integration): Update expected huggingface output * tests(integration): Update expected mlserver-mlflow output * contributing.md: Add update manifests instructions * gitignore: Ignore venv directory reqs: refresh requirements-integration.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor integration tests due to issue #218.
This is a workaround for the issue. At the same time, it is not needed to revert those back since up until now, integration tests were applying
seldondeploymentsto the namespace created by Juju. In production, this would bekubeflowand we would never apply something there.