schema: allow the gnome extension #3920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core22 is currently using the legacy implementation of remote-build and needs to allow gnome in order to work. The legacy code is safe, it will gracefully fail if used with the gnome extension at loading time LP: #1986962 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Codecov Report
@@ Coverage Diff @@
## main #3920 +/- ##
=======================================
Coverage 89.91% 89.91%
=======================================
Files 60 60
Lines 4165 4165
=======================================
Hits 3745 3745
Misses 420 420 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cmatsuoka
approved these changes
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
core22 is currently using the legacy implementation of remote-build and needs to allow gnome in order to work.
The legacy code is safe, it will gracefully fail if used with the gnome extension at loading time
LP: #1986962
Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com
make lint?pytest tests/unit?CRAFT-1385