From 9bbae5ded36e4e5f7aedf2e75517257be0f8d8d1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Sawicz?= Date: Fri, 10 May 2024 09:14:00 +0200 Subject: [PATCH] flutter: add missing `curl` build-package MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit At least on Launchpad, we otherwise end up with: ``` :: + flutter precache --linux :: Woah! You appear to be trying to run flutter as root. :: We strongly recommend running the flutter tool without superuser privileges. :: / :: 📎 :: :: Missing "curl" tool. Unable to download Dart SDK. :: Consider running "sudo apt-get install curl". ``` --- snapcraft/parts/plugins/flutter_plugin.py | 1 + tests/unit/parts/plugins/test_flutter_plugin.py | 1 + 2 files changed, 2 insertions(+) diff --git a/snapcraft/parts/plugins/flutter_plugin.py b/snapcraft/parts/plugins/flutter_plugin.py index 894ec25c18..bccd48c4de 100644 --- a/snapcraft/parts/plugins/flutter_plugin.py +++ b/snapcraft/parts/plugins/flutter_plugin.py @@ -83,6 +83,7 @@ def get_build_snaps(self) -> Set[str]: def get_build_packages(self) -> Set[str]: return { "clang", + "curl", "git", "cmake", "ninja-build", diff --git a/tests/unit/parts/plugins/test_flutter_plugin.py b/tests/unit/parts/plugins/test_flutter_plugin.py index b5c6628350..2392a5eae6 100644 --- a/tests/unit/parts/plugins/test_flutter_plugin.py +++ b/tests/unit/parts/plugins/test_flutter_plugin.py @@ -42,6 +42,7 @@ def test_get_build_packages(part_info): plugin = FlutterPlugin(properties=properties, part_info=part_info) assert plugin.get_build_packages() == { "clang", + "curl", "git", "cmake", "ninja-build",