Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(snap): add git as craft.git to snapcraft #5149

Merged
merged 5 commits into from
Nov 21, 2024

Conversation

dariuszd21
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

Adds a git binary as a craft.git, that'll be used by the craft libraries for the operation which require git client.

(CRAFT-3547)

@dariuszd21 dariuszd21 force-pushed the work/CRAFT-3547-add-git-to-snapcraft-snap branch from 2927ab8 to d8d3ed0 Compare November 19, 2024 23:36
Copy link
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

tests/spread/core24/craftgit/task.yaml Show resolved Hide resolved
snap/snapcraft.yaml Outdated Show resolved Hide resolved
@dariuszd21 dariuszd21 force-pushed the work/CRAFT-3547-add-git-to-snapcraft-snap branch from d8d3ed0 to 1a49c13 Compare November 20, 2024 19:53
Signed-off-by: Dariusz Duda <dariusz.duda@canonical.com>
Signed-off-by: Dariusz Duda <dariusz.duda@canonical.com>
@mr-cal mr-cal merged commit c7d11ac into main Nov 21, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants