Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support function timeout via async.timeout wrapper #1027

Merged
merged 1 commit into from
Mar 7, 2016

Conversation

ajfranzoia
Copy link
Contributor

Implements timeout feature discussed in #1007.
Follows @aearly advice on using a wrapper around the asynchronous functions. I changed the function arguments' order to match setTimeout signature.
If there are any mistakes or things that need modification, just let me know.
I can add the readme info if this looks good.

@aearly
Copy link
Collaborator

aearly commented Mar 6, 2016

I'm still 💯 on this, but master has changed significantly. Can you re-do the work? It also would be nice if you added a mocha_test too.

@aearly aearly added the feature label Mar 6, 2016
@ajfranzoia
Copy link
Contributor Author

Sure, I'll redo this and add a mocha test as well 👍

@ajfranzoia
Copy link
Contributor Author

Re-did this to support the new master and added a mocha test. I did some refactoring as well to the original code to make it clearer.

aearly added a commit that referenced this pull request Mar 7, 2016
Support function timeout via async.timeout wrapper
@aearly aearly merged commit 4f61814 into caolan:master Mar 7, 2016
@aearly aearly added this to the 2.0 milestone Mar 7, 2016
@meetwudi
Copy link
Contributor

meetwudi commented Mar 8, 2016

This is a nice feature! Probably add some docs of it? :)

@ajfranzoia
Copy link
Contributor Author

Added docs via #1051.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants