Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coveralls code-coverage out of date #1225

Closed
tekwiz opened this issue Jul 11, 2016 · 3 comments · Fixed by #1234
Closed

Coveralls code-coverage out of date #1225

tekwiz opened this issue Jul 11, 2016 · 3 comments · Fixed by #1234

Comments

@tekwiz
Copy link
Contributor

tekwiz commented Jul 11, 2016

It appears that the code-coverage results are out of date (invalid?). The most recent build was on March 31, and it appears that only karma.conf.js was evaluated (https://coveralls.io/github/caolan/async).
@tekwiz tekwiz mentioned this issue Jul 11, 2016
Closed
@megawac
Copy link
Collaborator

megawac commented Jul 11, 2016

Nevermind that fix didn't work
https://travis-ci.org/caolan/async/jobs/143901451#L1984

@megawac megawac reopened this Jul 11, 2016
@tekwiz
Copy link
Contributor Author

tekwiz commented Jul 12, 2016

@megawac There were some errors when the tests were run under nyc. I've submitted #1234 to fix that. I believe that is the underlying problem with the Coveralls report.

@tekwiz
Copy link
Contributor Author

tekwiz commented Jul 12, 2016

Bingo! The coveralls report ran after npm coveralls script line fix 00f12da
https://coveralls.io/builds/6972426

@tekwiz tekwiz mentioned this issue Jul 12, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix nyc/code-coverage testing tekwiz/async
3 participants
@tekwiz @megawac and others