async.waterfall fails when executed in the different node.js context

[alex-netkachov]

The following code fails with the "First argument to waterfall must be an array of functions" error in node.js:

require('vm').runInNewContext(
    'async.waterfall([ ], function (err) { console.log(err); });',
    { async : require('async'), console : console }
);

It looks like after node.js creates new environment, the following array comparison becomes invalid:

        if (tasks.constructor !== Array) {
          var err = new Error('First argument to waterfall must be an array of functions');
          return callback(err);
        }

Maybe it is better to use native Array.isArray function when it is available?

Thanks.

[brianmaissy]

This is related to both #294 and #179. I'll work on a comprehensive fix. Basically I'll replace all instances of Array type checking with a local checker function, which will use .isArray if available, and if not will fall down to the .toString approach. @caolan sounds good?

[patrickod]

+1 for this to be shipped. Just encountered it again today.

[theabraham]

+1 on this too. I'm having this same issue in node-webkit (issue #344.)

[heiwad]

I ran into this issue today in a node REPL in Emacs on Ubuntu.
The code posted at http://stackoverflow.com/a/17417137/2904811 fixed the issue for me.