async.each callback called multiple times if result is unshifted

[guyellis]

I expect this issue is closely related to #557 and #572

var async = require('async');

function func(done) {
  var arr = ['a'];
  async.each(arr, function(item, callback){
    return callback();
  }, function() {
    console.log('done');
    return done(arr);
  });
}

func(function(arr) {
  arr.unshift('a');
  // arr.shift('a') => no problem
});

"done" is printed an infinite number of times.

async version: 0.9.2

node version 0.12.7

[aearly]

Thanks for the bug report! 🐛 I think i know what's going on here.

[youqingkui]

I have not found this to be a bug

[guyellis]

I should have mentioned that my workaround is to clone arr in func() before calling done(). Not sure if that helps.

[guyellis]

@youqingkui You ran the snippet I posted and did not see "done" printed an infinite number of times? If so, what versions of node and async are you using?

[youqingkui]

@guyellis I use node is v4.0.0, async is 1.4.2

var async = require('async');
function func(done) {
  var arr = ['a'];
  async.each(arr, function(item, callback){
    return callback();
  }, function() {
    console.log('done');
    return done(arr);
  });
}

func(function(arr) {
  console.log(arr);
  arr.unshift('a');
  //arr.shift('a');nod
  console.log(arr);
});

// done
// [ 'a' ]
// [ 'a', 'a' ]

[guyellis]

@youqingkui You're right. The project that I'm working on has a very out-of-date version of async. Looks like it's my problem. Thanks for pointing this out! :)