Bug fix #968: uddate Readme for async.every()
#971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome. 👍 Thanks! |
aearly
added a commit
that referenced
this pull request
Dec 2, 2015
Bug fix #968: uddate Readme for `async.every()`
| functions have finished. Result will be either `true` or `false` depending on | ||
| the values of the async tests. | ||
| * `callback(result)` - *Optional* A callback which is called as soon as any iterator returns | ||
| `true`, or after all the iterator functions have finished. Result will be |
There was a problem hiding this comment.
should this be false instead of true?
There was a problem hiding this comment.
That's correct, it should be false. This was a copy-paste error, my bad.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor change in Readme for
async.every()to mention that not every iterator will run if one of them returns a falsy value (copy-pasted wording fromasync.some()).