Tap dependency update to v11

[exsilium]

Can we have nodeunit pump the tap dep to v11 please? Thank you! 🙇

[mreinstein]

unfortunately this isn't possible at the moment. nodeunit supports really, really old versions of node. tap v11 dropped support for older versions.

[exsilium]

Thanks @mreinstein! But what's the strategy here going forward from nodeunit perspective? I'd expect people stuck in legacy non-supported node versions are ok to lock themselves to a particular version of nodeunit as well. At some point the drop needs to happen, or not? Cheers! 🍻

[andy-ganchrow]

In the dependency tree of tap v10.7.3 is hoek v2.16.3 which apparently has a security vulnerability, so it would be great if this were resolved.

[mreinstein]

PR welcome!

[mreinstein]

something to note: nodeunit is essentially a deprecated testing library. There are a lot of modern alternatives that are better at this point.

[brettz9]

A warning to that effect would be very helpful!

[mreinstein]

A warning to that effect would be very helpful!

Yes, Caolan and I have been meaning to do that for a while. Finally done via ec2ea88, thanks for the reminder. 👍

[brodycj]

FYI update to tap 12 in PR #356 seems to pass old Node.js versions back to 0.12, though with a few ugly engine warnings.

[mreinstein]

closing since tap has moved on from v11