Skip to content
This repository has been archived by the owner on Sep 17, 2021. It is now read-only.

Floats improperly handled in axis scaling / points calculation #84

Closed
Cody-G-G opened this issue Feb 14, 2017 · 2 comments
Closed

Floats improperly handled in axis scaling / points calculation #84

Cody-G-G opened this issue Feb 14, 2017 · 2 comments

Comments

@Cody-G-G
Copy link

Cody-G-G commented Feb 14, 2017

My dataset has the following X values: 1.78, 1.83, 2.0, 2.46.

16731731_1255859791150820_448227196_o

As you can see, it gets quite ugly...some (simple?) solutions would be to limit the number of digits after the decimal point (I imagine 2 digits for the fractional part would be sufficient for scenarios that involve mobile graphs....), or rounding the fractional part after a number of digits over the decimal point.

Edit: I see this is an issue from the lodash range method...maybe since lodash is MIT licensed the method can simply be copied and improved with the proper handling?

@marzolfb
Copy link
Contributor

This is likely a duplicate of #28 - but will need to take a closer look later.

@marzolfb
Copy link
Contributor

@Cody-G-G See my design thoughts on #28 - you have any feedback to contribute there?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants