Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macOS python wheel for 5.0.0rc4 claims to be universal2 but is actually just amd64 #2066

Closed
Tracked by #2081
twizmwazin opened this issue Jun 27, 2023 · 8 comments
Closed
Tracked by #2081

macOS python wheel for 5.0.0rc4 claims to be universal2 but is actually just amd64 #2066

twizmwazin opened this issue Jun 27, 2023 · 8 comments
Labels
bug Something is not working as it should build & packaging Build system and packaging related python bindings
Milestone
v5.0.4

Comments

@twizmwazin
Copy link
Contributor

When pip installing capstone on an apple silicon mac, pip will select the universal2 wheel as compatible. However, it then fails to import because the library cannot be loaded due to the architecture mismatch. Installing from source with pip install --pre --no-binary capstone capstone seems to work fine however.
@twizmwazin twizmwazin mentioned this issue Jun 27, 2023
Closed
@XVilka
Copy link
Contributor

XVilka commented Jun 28, 2023

Likely changes needed in https://github.com/capstone-engine/capstone/blob/next/bindings/python/build_wheel.sh

@XVilka
Copy link
Contributor

XVilka commented Jun 28, 2023 •
edited
Loading

Maybe cibuildwheel could be used:

This was referenced Jul 10, 2023
Closed
Closed
@XVilka XVilka mentioned this issue Jul 20, 2023
Merged
@XVilka
Copy link
Contributor

XVilka commented Jul 20, 2023

See #2099

@kabeor
Copy link
Member

kabeor commented Jul 21, 2023 •
edited
Loading

should have been fixing in #2099. will publish in 5.0.1.

@patryk4815 patryk4815 mentioned this issue Jul 30, 2023
Closed
@Rot127 Rot127 mentioned this issue Aug 24, 2023
Closed
@cunji123
Copy link

WOW!

@Grazfather
Copy link

This is still broken on 5.0.1 for me.

@Rot127 Rot127 added this to the v5.0.2 milestone Mar 19, 2024
@Rot127 Rot127 added bug Something is not working as it should python bindings build & packaging Build system and packaging related labels Mar 20, 2024
@Rot127 Rot127 mentioned this issue Mar 20, 2024
Closed
@Rot127 Rot127 mentioned this issue Mar 29, 2024
Closed
@DarkaMaul DarkaMaul mentioned this issue Apr 4, 2024
Closed
@Rot127 Rot127 mentioned this issue Apr 24, 2024
Closed
@d235j
Copy link

d235j commented Aug 14, 2024

This bug is still present in v5.0.2. In addition, the ARM wheel ships an x86_64 .dylib.

@Rot127
Copy link
Collaborator

Rot127 commented Sep 10, 2024

Fixed in v5.0.3. This time for real

@Rot127 Rot127 closed this as completed Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something is not working as it should build & packaging Build system and packaging related python bindings
Projects
None yet
Milestone
v5.0.4
Development

No branches or pull requests
7 participants
@d235j @XVilka @Grazfather @twizmwazin @kabeor @cunji123 @Rot127