Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skipdata doesn't work correctly from python #2336

Closed
cyb3rc opened this issue Apr 24, 2024 · 9 comments
Closed

skipdata doesn't work correctly from python #2336

cyb3rc opened this issue Apr 24, 2024 · 9 comments
Labels
bug Something is not working as it should python bindings
Milestone

Comments

@cyb3rc
Copy link

cyb3rc commented Apr 24, 2024

Work environment

Questions Answers
OS/arch/bits MacOS, arm64
Architecture arm64
Source of Capstone git clone, pip
Version/git commit v5.0.1

Instruction bytes giving faulty results

0xc0, 0x03, 0x5f, 0xd6, 0x98, 0xf2, 0xff, 0xff, 0xc0, 0x03, 0x5f, 0xd6

Expected results

It should be:

1000  c0 03 5f d6  ret
1004  98 f2 ff ff  .byte	0x98, 0xf2, 0xff, 0xff
1008  c0 03 5f d6  ret

Steps to get the wrong result

With cstool we got expected result:

$ cstool -s arm64 "c0035fd698f2ffffc0035fd6"
1000  c0 03 5f d6  ret
1004  98 f2 ff ff  .byte	0x98, 0xf2, 0xff, 0xff
1008  c0 03 5f d6  ret

With Python code

from capstone import *

CODE = b"\xc0\x03\x5f\xd6\x98\xf2\xff\xff\xc0\x03\x5f\xd6"

md = Cs(CS_ARCH_ARM64, CS_MODE_ARM)
md.skipdata = True
for insn in md.disasm(CODE, 0x1000):
    print("%x  %s %s %s" % (insn.address, "".join(["%02x " % b for b in insn.bytes]), insn.mnemonic, insn.op_str))

Got only first instruction

1000  c0 03 5f d6  ret

NOTE

  1. Compiled test_skipdata.c works as expected.
  2. Use of compiled dynamic library from v5.0.1 release sources from python returns invalid result.

Probably the issue with dynamic library.

@Rot127 Rot127 added python bindings bug Something is not working as it should labels Apr 25, 2024
@Rot127 Rot127 added this to the v5.0.2 milestone Apr 25, 2024
@u07
Copy link

u07 commented May 30, 2024

I can confirm. Spend a day until noticed that PE is only half-decoded. Capstone breaks on this instruction:

image

ver 5.0.1, skipdata = True, python 3.8.10, Win7 64

@u07
Copy link

u07 commented May 30, 2024

Any advices about how to overcome this?..

@Rot127
Copy link
Collaborator

Rot127 commented Jun 19, 2024

Sorry for the late answer. Currently, we are really busy with many other construction sides in Capstone. So the Python bindings don't get the love they would actually need. We first want to bring the C code base up to date. Because the Python bindings possibly get a complete rewrite. For those two reasons, no one looked at this one yet.

Although, you can try to use the next branch (currently only usable with <= Python3.11).

@cyb3rc
Copy link
Author

cyb3rc commented Jun 27, 2024

@Rot127 Thanks for response. At least we know that it is in a road map. We'll be waiting for next release.

@Amoystyle
Copy link

The library installed through the PyPi package was found to be invalid because the definition of CS_OPT_ON in python and dll was different。

# bindings/python/capstone/__init__.py
CS_OPT_ON = 1 << 0              # Turn ON an option (CS_OPT_DETAIL)

#include/capstone/capstone.h
CS_OPT_ON = 3, ///< Turn ON an option (CS_OPT_DETAIL, CS_OPT_SKIPDATA).

The next branch has fixed this.

@Rot127
Copy link
Collaborator

Rot127 commented Aug 16, 2024

@Amoystyle In the v5 branch CS_OPT_ON == 3 in the Python bindings and the c header.
So this might not be the reason.

@Amoystyle
Copy link

@Rot127 I see that the latest version 5.0.2 has fixed this bug

[v5] python: Fix definition of capstone syntax value option constants by @nmeum in #2240

@Rot127
Copy link
Collaborator

Rot127 commented Aug 24, 2024

@cyb3rc Can you please try it and close this one if it works for you?

@cyb3rc
Copy link
Author

cyb3rc commented Sep 9, 2024

@Rot127 Checked with v.5.0.3. It works! Thanks a lot!

@cyb3rc cyb3rc closed this as completed Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working as it should python bindings
Projects
None yet
Development

No branches or pull requests

4 participants