Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a Debian Package on releases #2398

Closed
1 of 5 tasks
AndrewQuijano opened this issue Jul 15, 2024 · 4 comments · Fixed by #2521
Closed
1 of 5 tasks

Create a Debian Package on releases #2398

AndrewQuijano opened this issue Jul 15, 2024 · 4 comments · Fixed by #2521
Labels
build & packaging Build system and packaging related enhancement
Milestone

Comments

@AndrewQuijano
Copy link
Contributor

AndrewQuijano commented Jul 15, 2024

Feature

  • New architecture module
  • Support for processor extension
  • Add more instruction details (elaborated below)
  • Binding support for: language
  • Other (elaborated below)

Describe the feature you'd like
Please update your CI such that when you create a release, you also create a Debian Package, I provided an example of how this is used for PANDA.

https://github.com/panda-re/panda/releases/tag/v1.8.34
https://github.com/panda-re/panda/tree/dev/panda/debian

Additional context
Utilizing a Debian package would be useful to save time on builds as the users would only need to download the package instead of repeatedly compile it for every build. This process should not be too difficult to build and would greatly improve efficiency as things like branch v5 wouldn't be needed as someone can just grab the package from the release.

Based on the screenshots, it shows that the current apt packages only have the outdated versions of libcapstone4 and libcapstone-dev. The package I propose should have both packages in one go.

image
image

@Rot127 Rot127 added enhancement build & packaging Build system and packaging related labels Jul 16, 2024
@Rot127 Rot127 added this to the v6 milestone Jul 16, 2024
@Rot127 Rot127 moved this to Todo in Capstone V6 Plan Jul 16, 2024
@kabeor
Copy link
Member

kabeor commented Jul 26, 2024

It would be great if you could help contribute a PR for this feature.

@Rot127 Rot127 modified the milestones: v6 - Alpha, v6 - Beta Aug 26, 2024
@AndrewQuijano
Copy link
Contributor Author

@kabeor

Sure I can give it a try, would be nice to know the following as I'm not familiar with libcapstone and am just going to rely a lot what was done here.
https://github.com/panda-re/panda/blob/dev/panda/debian/Dockerfile

1- where are the output files of make install located at?
2- Where would you like me to put the workflow to create the package and put the debian package in the release?

@AndrewQuijano
Copy link
Contributor Author

@kabeor, I started some initial work on making the Capstone Debian package. I'm stuck on something, but if you got a bit of time to help with this last step, that would be amazing. Not sure when I can get another crack at this.

@AndrewQuijano
Copy link
Contributor Author

@kabeor Actually, I figured it out, the packaging seems to work, updated your CI too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build & packaging Build system and packaging related enhancement
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants