fix(ui): Fix incorrect default value setting OR operator when parsing React configs #103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The OR operator used to set default values for
REACT_APP_ALLOW_CUSTOM_STREAM
andREACT_APP_ALLOW_CUSTOM_TEAM
is incorrect.Example:
What we want is when
REACT_APP_ALLOW_CUSTOM_STREAM
is defined, return the value ofREACT_APP_ALLOW_CUSTOM_STREAM
, otherwise returntrue
. However, whenREACT_APP_ALLOW_CUSTOM_STREAM
isfalse
:which is incorrect.
This PR fixes this by replacing the OR operator with a ternary operator to check if the environment variable is defined or not, and returns that value if it is, and returns true if it isn't: