Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Modify UI stream & team form #97

Merged
merged 11 commits into from
May 28, 2024
Merged

feat: Modify UI stream & team form #97

merged 11 commits into from
May 28, 2024

Conversation

shydefoo
Copy link
Contributor

Description

  • This PR makes allowing the creation of new teams / streams on the UI configurable
  • The default is still to allow new teams / streams to be added from the UI
  • Modifies the validation of team and stream name to allow _, according to the allowed values described here

@shydefoo
Minor features to mlp
afa1871 
* Modify project creation form to conditionally allow custom
  team/stream
* Add new validation for team and stream to match k8s valid label
  values, except for capital letters
@shydefoo shydefoo force-pushed the modify-ui-validation branch from 300c4de to 76c975b Compare May 15, 2024 09:36
@shydefoo shydefoo marked this pull request as ready for review May 16, 2024 05:30
@deadlycoconuts
Copy link
Contributor

Sorry to ruin the party @shydefoo but after #93 got merged, there are a couple of merge conflicts (but more importantly some refactoring to do) ><!

@shydefoo shydefoo changed the title feat: Modify UI stream & team form [DO NOT MERGE] feat: Modify UI stream & team form May 20, 2024
@shydefoo shydefoo changed the title [DO NOT MERGE] feat: Modify UI stream & team form feat: Modify UI stream & team form May 20, 2024
@codecov Codecov
Copy link

codecov bot commented May 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.58%. Comparing base (fc18b5c) to head (46bc0fd).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #97   +/-   ##
=======================================
  Coverage   58.58%   58.58%           
=======================================
  Files          43       43           
  Lines        2091     2091           
=======================================
  Hits         1225     1225           
  Misses        721      721           
  Partials      145      145
Flag Coverage Δ
api-test 58.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shydefoo
Copy link
Contributor Author

shydefoo commented May 20, 2024 •
edited
Loading

Sorry to ruin the party @shydefoo but after #93 got merged, there are a couple of merge conflicts (but more importantly some refactoring to do) ><!

alright fixed @deadlycoconuts

@shydefoo
Copy link
Contributor Author

@deadlycoconuts @leonlnj poke

@shydefoo shydefoo force-pushed the modify-ui-validation branch from 04ddd40 to 46bc0fd Compare May 27, 2024 06:13
leonlnj
leonlnj approved these changes May 27, 2024
View reviewed changes
Copy link

@leonlnj leonlnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, lgtm!

deadlycoconuts
deadlycoconuts approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@deadlycoconuts deadlycoconuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes too! 🙏🏼🚀

@shydefoo shydefoo merged commit 76bbea5 into main May 28, 2024
9 of 10 checks passed
@shydefoo shydefoo deleted the modify-ui-validation branch May 28, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deadlycoconuts deadlycoconuts deadlycoconuts approved these changes

@leonlnj leonlnj leonlnj approved these changes

@ariefrahmansyah ariefrahmansyah Awaiting requested review from ariefrahmansyah

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shydefoo @deadlycoconuts @leonlnj