feat(core): create heatmap chart #1200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akshat55
requested review from
zvonimirfras and
Donisius
and removed request for
a team
theiliad
requested changes
Dec 15, 2021
| */ | ||
| title?: string; | ||
| type: ColorLegendType; | ||
| }; |
There was a problem hiding this comment.
would this add colorLegend to the types for the rest of the charts? is that what we want?
There was a problem hiding this comment.
The option currently is ONLY used by Heatmap - if we are going to have future charts that use color legend, it makes sense to put it under the legend option, since it is a legend.
Setting the type or title will not do enable or do anything in other chart types.
There was a problem hiding this comment.
Let's (for now) extend this to a HeatmapLegendOptions and only include there, as we haven't figured out how this new legend type will work with other chart types
packages/core/src/components/axes/two-dimensional-hover-axes.ts
Outdated
Show resolved
Hide resolved
packages/core/src/components/axes/two-dimensional-hover-axes.ts
Outdated
Show resolved
Hide resolved
theiliad
requested changes
Dec 21, 2021
|
@theiliad, made them experimental and moved color legend under heatmap options |
theiliad
approved these changes
Dec 24, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
Demo screenshot or recording
Review checklist (for reviewers only)