-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): create heatmap chart #1200
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I think it looks ok, just a couple of considerations around efficiency and duplication
*/ | ||
title?: string; | ||
type: ColorLegendType; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would this add colorLegend
to the types for the rest of the charts? is that what we want?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The option currently is ONLY used by Heatmap - if we are going to have future charts that use color legend, it makes sense to put it under the legend option, since it is a legend.
Setting the type
or title
will not do enable or do anything in other chart types.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's (for now) extend this to a HeatmapLegendOptions
and only include there, as we haven't figured out how this new legend type will work with other chart types
packages/core/src/components/axes/two-dimensional-hover-axes.ts
Outdated
Show resolved
Hide resolved
packages/core/src/components/axes/two-dimensional-hover-axes.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the 2 remaining changes for hover-axis.ts
& the legend types requested above
Also @Akshat55 could you pls add the experimental
flag to the demos?
@theiliad, made them experimental and moved color legend under heatmap options |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tried to look at everything 👍🏻
Updates
Demo screenshot or recording
Review checklist (for reviewers only)