Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(umd): Issue 1646 - change process.env.NODE_ENV to string #1649

Merged
merged 14 commits into from
Aug 14, 2023
Merged

fix(umd): Issue 1646 - change process.env.NODE_ENV to string #1649

merged 14 commits into from
Aug 14, 2023

Conversation

nstuyvesant
Copy link
Contributor

Updates

@nstuyvesant nstuyvesant requested review from theiliad, Akshat55 and a team as code owners August 11, 2023 19:13
@nstuyvesant nstuyvesant requested review from zvonimirfras and removed request for a team August 11, 2023 19:13
@netlify
Copy link

netlify bot commented Aug 11, 2023 •
edited
Loading

✅ Deploy Preview for carbon-charts-core ready!

Name Link
🔨 Latest commit e92e0c4
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-core/deploys/64d95635f1b8210008a9a858
😎 Deploy Preview https://deploy-preview-1649--carbon-charts-core.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 11, 2023 •
edited
Loading

✅ Deploy Preview for carbon-charts-angular ready!

Name Link
🔨 Latest commit e92e0c4
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-angular/deploys/64d95635b1678400088cd01c
😎 Deploy Preview https://deploy-preview-1649--carbon-charts-angular.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 11, 2023 •
edited
Loading

✅ Deploy Preview for carbon-charts-react ready!

Name Link
🔨 Latest commit e92e0c4
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-react/deploys/64d95635a6b3810008c251ff
😎 Deploy Preview https://deploy-preview-1649--carbon-charts-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

theiliad
theiliad approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@theiliad theiliad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theiliad theiliad merged commit 8e11271 into carbon-design-system:master Aug 14, 2023
1 check passed
@theiliad theiliad deleted the issue-1646 branch August 14, 2023 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theiliad theiliad theiliad approved these changes

@Akshat55 Akshat55 Awaiting requested review from Akshat55

@zvonimirfras zvonimirfras Awaiting requested review from zvonimirfras zvonimirfras is a code owner automatically assigned from carbon-design-system/carbon-charts

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: UMD bundle not working as expected
2 participants
@nstuyvesant @theiliad