Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pie-donut): formatter not recieving entire value #1662

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

RiyaJethwa
Copy link
Contributor

@RiyaJethwa RiyaJethwa commented Sep 18, 2023

Updates

  • Added percentageValue property to formatter
  • User can now edit labels

Demo screenshot or recording

image

@RiyaJethwa RiyaJethwa requested review from zvonimirfras and removed request for a team September 18, 2023 14:38
@netlify
Copy link

netlify bot commented Sep 18, 2023

Deploy Preview for carbon-charts-react ready!

Name Link
🔨 Latest commit 8fe2597
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-react/deploys/650861057e787a0008ad1df1
😎 Deploy Preview https://deploy-preview-1662--carbon-charts-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 18, 2023

Deploy Preview for carbon-charts-core ready!

Name Link
🔨 Latest commit 8fe2597
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-core/deploys/6508610570c0370008946063
😎 Deploy Preview https://deploy-preview-1662--carbon-charts-core.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@carbon-bot
Copy link
Collaborator

carbon-bot commented Sep 18, 2023

DCO Assistant Lite bot All contributors have signed the DCO.

@netlify
Copy link

netlify bot commented Sep 18, 2023

Deploy Preview for carbon-charts-angular ready!

Name Link
🔨 Latest commit 8fe2597
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-angular/deploys/65086105d7cc5900083374fd
😎 Deploy Preview https://deploy-preview-1662--carbon-charts-angular.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@RiyaJethwa
Copy link
Contributor Author

I have read the DCO document and I hereby sign the DCO.

@RiyaJethwa RiyaJethwa closed this Sep 18, 2023
@RiyaJethwa RiyaJethwa deleted the labelfix branch September 18, 2023 14:45
@RiyaJethwa RiyaJethwa restored the labelfix branch September 18, 2023 14:45
@theiliad theiliad reopened this Sep 18, 2023
@theiliad theiliad merged commit 9facba4 into carbon-design-system:master Sep 18, 2023
5 checks passed
@RiyaJethwa RiyaJethwa deleted the labelfix branch September 19, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants