-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(release): separate docs search index generation #1884
fix(release): separate docs search index generation #1884
Conversation
✅ Deploy Preview for carbon-charts-core ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-charts-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-charts-angular ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-charts-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
fix(release): cleanup chore(deps): bump fix(release): step chore(dco): bump action version chore(deps): bump chore(deps): bump vue chore(deps): bump chore(deps): bump dependencies
52d0863
to
c67d700
Compare
node-version: '20.x' | ||
cache: 'yarn' | ||
registry-url: 'https://registry.npmjs.org/' | ||
always-auth: true | ||
auth-token: ${{ secrets.NPM_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eliminate need for explicit minor versions, set yarn cache and npmjs authentication here instead of below.
- name: Set git user to carbon-bot | ||
run: | | ||
git config --global user.email "carbon@us.ibm.com" | ||
git config --global user.name "carbon-bot" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved these up closer to the checkout.
- name: Generate search index for docs website | ||
run: lerna run build:search --scope @carbon/charts-docs # should be committed in next step |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Separated this from docs package build.
|
||
- name: Create version and change logs | ||
- name: Create version and change logs and commit to master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this commits the new version numbers to master, it can also commit the rebuilt search index for the docs website.
- name: Commit and push changes (if there are any) | ||
run: | | ||
git add . | ||
if ! git diff-index --quiet HEAD; then | ||
git commit -m "skip-release - chore(build): updated search index for docs" | ||
git push origin master | ||
fi | ||
env: | ||
GH_TOKEN: ${{ secrets.GH_TOKEN }} | ||
|
||
- name: Publish to npmjs registry and Github | ||
run: | | ||
npm config set //registry.npmjs.org/:_authToken=${{ secrets.NPM_TOKEN }} -q | ||
npx lerna publish from-git --yes --force-publish |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already handled above.
"build": "yarn build:search && yarn build:docs && yarn files:pages && yarn build:api:docs", | ||
"dev": "vite --port 3000", | ||
"build": "yarn build:docs && yarn files:pages && yarn build:api:docs", | ||
"dev": "yarn build:search && vite --port 3000", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed building of search index from docs package build. Ensure index is rebuilt before previewing site.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Updates