Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(a11y): add aria-label to <svg> elements #1892

Merged
merged 2 commits into from
Sep 16, 2024
Merged

feat(a11y): add aria-label to <svg> elements #1892

merged 2 commits into from
Sep 16, 2024

Conversation

theiliad
Copy link
Member

@theiliad theiliad commented Sep 16, 2024 •
edited
Loading

Closes #1872
Closes #1882

@theiliad theiliad requested a review from a team as a code owner September 16, 2024 17:43
@netlify Netlify
Copy link

netlify bot commented Sep 16, 2024 •
edited
Loading

✅ Deploy Preview for carbon-charts-angular ready!

Name Link
🔨 Latest commit bb86752
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-angular/deploys/66e8716391815f000899c3e6
😎 Deploy Preview https://deploy-preview-1892--carbon-charts-angular.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Sep 16, 2024 •
edited
Loading

✅ Deploy Preview for carbon-charts-react ready!

Name Link
🔨 Latest commit bb86752
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-react/deploys/66e871636fa87c0008c6af26
😎 Deploy Preview https://deploy-preview-1892--carbon-charts-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Sep 16, 2024 •
edited
Loading

✅ Deploy Preview for carbon-charts-core ready!

Name Link
🔨 Latest commit bb86752
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-core/deploys/66e87163ac824700087261bf
😎 Deploy Preview https://deploy-preview-1892--carbon-charts-core.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Sep 16, 2024 •
edited
Loading

✅ Deploy Preview for carbon-charts-docs ready!

Name Link
🔨 Latest commit bb86752
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-docs/deploys/66e8716361a05500083a4928
😎 Deploy Preview https://deploy-preview-1892--carbon-charts-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@theiliad theiliad merged commit 65d40e5 into master Sep 16, 2024
3 of 7 checks passed
@theiliad theiliad deleted the add-aria-labels-to-svgs branch September 16, 2024 17:58
nstuyvesant added a commit to nstuyvesant/carbon-charts that referenced this pull request Sep 29, 2024
@nstuyvesant
skip-release - chore(branch rename): rename master to main
366465d 
skip-release chore(deps): bump

feat(a11y): add aria-label to <svg> elements (carbon-design-system#1892)

* feat(a11y): add aria-label to <svg> elements

* qa

chore(release): publish 1.22.0

skip-release chore(deps): bump

skip-release chore(deps): bump

skip-release chore(deps): bump

skip-release chore(deps): bump

skip-release chore(deps): bump
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@theiliad