Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add selected state for default columns in data tables #124

Closed
dianasanborn opened this issue Jun 14, 2019 · 8 comments
Closed

Add selected state for default columns in data tables #124

dianasanborn opened this issue Jun 14, 2019 · 8 comments

Comments

@dianasanborn
Copy link

For the different data column grouped columns, there's no option to have a default row have a selected state to match the selectable enabled state.

Screen Shot 2019-06-14 at 2 17 22 PM

Applications grouped column: correct selected state background color
Role + Status grouped column: incorrect background color—I can only get to a hover state

@dianasanborn
Copy link
Author

Side comment: It seems a little confusing when the selected row color is the same as the column header color. Thoughts?

Screen Shot 2019-06-14 at 2 56 11 PM

@stale
Copy link

stale bot commented Jun 28, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the inactive label Jun 28, 2019
@stale
Copy link

stale bot commented Jul 1, 2019

As there's been no activity since this issue was marked as stale, we are auto-closing it.

@aagonzales
Copy link
Member

@dianatran18 Its under the "selectable" category not the default. You have to switch categories.
image

@aagonzales
Copy link
Member

Missing states in selectable category for:

  • selected + hover

@dianasanborn
Copy link
Author

Ah yes sorry I saw your slack thread with Marcel before and I forgot I opened this.

Thank you!

@marceltrautmann
Copy link

.

@aagonzales
Copy link
Member

Fixed! Available in next kit update.
(add to 10.5 release notes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants