Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dark theme, Input Modal/Form, Sketch kit] Input fields background is not correct #164

Closed
aagonzales opened this issue Jul 31, 2019 · 3 comments

Comments

@aagonzales
Copy link
Member

@shixiedesign commented on Wed Jul 31 2019

Dark theme, Form/Input Modal Input fields background is currently darker than background. Should be using field-02 token, which is lighter than background.

Current kit Gray100 & Gray90 theme Form modal component

image

Should be

image

@aagonzales
Copy link
Member Author

aagonzales commented Aug 12, 2019

Additional fixes:

  • [form] swapped all "form / ... / item" to be standard component symbols (ie. 'form/.../item/text input' -> text input/.../enabled
    • Deleted all "form / ... / item" symbols
    • image
    • image
    • Group category no longer need: "form / on page / group / two column"
  • [form / modal] replaced custom buttons with buttons from modal component
    • removed: form / modal / pieces / button / 01 single button
    • removed: form / modal / pieces / button / 02 two button
    • image
  • [radio button]: added horizontal group symbols, added category of "vertical group"
    • image

@aagonzales
Copy link
Member Author

aagonzales commented Aug 12, 2019

  • White
  • G10
  • G90
  • G100

@aagonzales
Copy link
Member Author

Fixed! Available in the next kit update.

Add to v10.5 release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant