Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Masthead L0 active link: selected menu item knob not working in a new tab #3912

Closed
larahanlon2 opened this issue Sep 10, 2020 · 3 comments
Closed
Assignees
Labels
bug Something isn't working dev Needs some dev work severity 4 Affects minor functionality, no workaround needed
Milestone

Comments

@larahanlon2
Copy link

larahanlon2 commented Sep 10, 2020

Detailed description

Describe in detail the issue you're having.
In Storybook, when I change the selected menu item knob, the update renders correctly in the same view but if I open the page in a new tab the active state is missing.

Screen Shot 2020-09-10 at 3 01 31 PM

Is this a feature request (new component, new icon), a bug, or a general issue?
This could be Storybook issue, not sure.

Is this issue related to a specific component?
Masthead L0

What did you expect to happen? What happened instead? What would you like to see changed?
In this example, I expected to see a blue underline below Products & Solutions when I opened the page in a new tab.

What browser are you working in?
Chrome

Steps to reproduce the issue

  1. Open the masthead here: https://ibmdotcom-react-canary.mybluemix.net/?path=/story/components-masthead--default
  2. Change the selected menu item knob at the bottom of add-ons panel to reflect one of the L0 menu items
  3. Once you see the update, click on the 'open canvas in new tab' icon in the top right of Storybook
@larahanlon2 larahanlon2 added the bug Something isn't working label Sep 10, 2020
@annawen1
Copy link
Member

annawen1 commented Sep 10, 2020

Yep this is a storybook issue, specifically with special characters like &. When opening a new tab, storybook passes all the changed knobs into url parameters and characters like & can cause issues. If you try changing the selected menu item knob to a menu item that does not contain & (ie. Explore more) and then open a new tab, the blue underline will appear correctly.

@asudoh
Copy link
Contributor

asudoh commented Sep 10, 2020

Refs storybookjs/storybook#11641.

@jacobottesen-dgc jacobottesen-dgc added the dev Needs some dev work label Sep 15, 2020
@RobertaJHahn RobertaJHahn added the severity 4 Affects minor functionality, no workaround needed label Sep 17, 2020
@RobertaJHahn RobertaJHahn added this to the Sprint 20-21 milestone Sep 17, 2020
@ariellalgilmore
Copy link
Member

As @asudoh comment references, this has been fixed and can be closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dev Needs some dev work severity 4 Affects minor functionality, no workaround needed
Projects
None yet
Development

No branches or pull requests

8 participants