Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lead space] Deprecate "default" and name it super #5796

Closed
2 tasks
RobertaJHahn opened this issue Apr 16, 2021 · 2 comments
Closed
2 tasks

[Lead space] Deprecate "default" and name it super #5796

RobertaJHahn opened this issue Apr 16, 2021 · 2 comments
Assignees
@ariellalgilmore
Labels
dev Needs some dev work package: react Work necessary for the Carbon for IBM.com react components package package: web components Work necessary for the IBM.com Library web components package priority: high storybook
Milestone
Sprint 21-11

Comments

@RobertaJHahn
Copy link

RobertaJHahn commented Apr 16, 2021 •
edited by photodow
Loading

User Story

As a [user role below]:
Carbon for IBM.com user

I need to:
have the aligned / available Lead space storybook variants

so that I can:
properly create the ibm.com web pages

Additional information

Naming:

  • Deprecate name "Default", so our Tall = 560, Super = 640

Desired storybook for Lead space is:

Lead space
|--- Super
|--- Tall
|--- Medium
|--- Short
|--- Centered

image.png

Functional specs

https://ibm.box.com/s/oaua3t438za3u5wsuaj9dpgp99r7746d

Acceptance criteria

  • Variant versions as documented in the functional specs are created
  • Aligned storybook naming between React and Web components is complete
@RobertaJHahn RobertaJHahn added dev Needs some dev work package: web components Work necessary for the IBM.com Library web components package storybook labels Apr 16, 2021
This was referenced Apr 16, 2021
Closed
Closed
@RobertaJHahn
Copy link
Author

Reviewed in the April 19 engineering refinement meeting. Sized based on the discussions. Shixie will update this issue with the additional details discussed in the meeting. Work was not scheduled in the meeting. Including in sprint 21-10 based on the bug takedown priority.

cc: @shixiedesign @jeffchew

@RobertaJHahn RobertaJHahn added this to the Sprint 21-10 milestone Apr 19, 2021
@RobertaJHahn RobertaJHahn added the package: react Work necessary for the Carbon for IBM.com react components package label May 5, 2021
@RobertaJHahn RobertaJHahn changed the title Web Components: [Lead space] Create and / or rename variants per functional specs and align with React storybook [Lead space] Deprecate "default" naming in storybook May 5, 2021
@RobertaJHahn RobertaJHahn changed the title [Lead space] Deprecate "default" naming in storybook [Lead space] Deprecate "default" and name it super May 5, 2021
@RobertaJHahn
Copy link
Author

Duplicate. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ariellalgilmore ariellalgilmore

Labels
dev Needs some dev work package: react Work necessary for the Carbon for IBM.com react components package package: web components Work necessary for the IBM.com Library web components package priority: high storybook
Projects
None yet
Milestone
Sprint 21-11
Development

No branches or pull requests
2 participants
@ariellalgilmore @RobertaJHahn